adamsaghy commented on code in PR #2566:
URL: https://github.com/apache/fineract/pull/2566#discussion_r962966197
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java:
##########
@@ -167,9 +167,26 @@ public CommandProcessingResult
applyDelinquencyTagToLoan(Long loanId, JsonComman
@Override
public void applyDelinquencyTagToLoan(Long loanId, Long ageDays) {
final Loan loan =
this.loanRepository.findOneWithNotFoundDetection(loanId);
- final DelinquencyBucket delinquencyBucket =
loan.getLoanProduct().getDelinquencyBucket();
- if (delinquencyBucket != null) {
- lookUpDelinquencyRange(loan, delinquencyBucket, ageDays);
+ applyDelinquencyTagToLoan(loan, ageDays);
+ }
+
+ @Override
+ public void applyDelinquencyTagToLoan(final Loan loan, Long ageDays) {
+ if (loan.hasDelinquencyBucket()) {
+ lookUpDelinquencyRange(loan,
loan.getLoanProduct().getDelinquencyBucket(), ageDays);
+ }
+ }
+
+ @Override
+ public void removeDelinquencyTagToLoan(final Loan loan) {
+ setLoanDelinquencyTag(loan, null);
+ }
+
+ @Override
+ public void cleanLoanDelinquencyTags(Loan loan) {
Review Comment:
hmm... still i dont think you can delete history entries... if you are
undoing things, like repayment or anything it goes back in state and if there
is no active loan, the classification needs to be lifted, but still...history
is history...
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java:
##########
@@ -167,9 +167,26 @@ public CommandProcessingResult
applyDelinquencyTagToLoan(Long loanId, JsonComman
@Override
public void applyDelinquencyTagToLoan(Long loanId, Long ageDays) {
final Loan loan =
this.loanRepository.findOneWithNotFoundDetection(loanId);
- final DelinquencyBucket delinquencyBucket =
loan.getLoanProduct().getDelinquencyBucket();
- if (delinquencyBucket != null) {
- lookUpDelinquencyRange(loan, delinquencyBucket, ageDays);
+ applyDelinquencyTagToLoan(loan, ageDays);
+ }
+
+ @Override
+ public void applyDelinquencyTagToLoan(final Loan loan, Long ageDays) {
+ if (loan.hasDelinquencyBucket()) {
+ lookUpDelinquencyRange(loan,
loan.getLoanProduct().getDelinquencyBucket(), ageDays);
+ }
+ }
+
+ @Override
+ public void removeDelinquencyTagToLoan(final Loan loan) {
+ setLoanDelinquencyTag(loan, null);
+ }
+
+ @Override
+ public void cleanLoanDelinquencyTags(Loan loan) {
Review Comment:
hmm... still i dont think we should delete history entries... if you are
undoing things, like repayment or anything it goes back in state and if there
is no active loan, the classification needs to be lifted, but still...history
is history...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
