adamsaghy commented on code in PR #2783:
URL: https://github.com/apache/fineract/pull/2783#discussion_r1039264757
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java:
##########
@@ -91,6 +84,29 @@ public AccountSummaryCollectionData
retrieveClientAccountDetails(final Long clie
return new AccountSummaryCollectionData(loanAccounts, glimAccounts,
savingsAccounts, shareAccounts, guarantorloanAccounts);
}
+ @Override
+ public AccountSummaryCollectionData retrieveClientAccountDetails(String
externalId) {
Review Comment:
We discussed we dont need this. You can resolve the internal id at the API
layer, the same way as it was done for the Loan transactions. This way we dont
need to introduce new methods and business logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
