adamsaghy commented on code in PR #2783:
URL: https://github.com/apache/fineract/pull/2783#discussion_r1039275106


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResourceSwagger.java:
##########
@@ -252,6 +252,8 @@ private GetClientsGroups() {}
         public List<GetClientsGroups> groups;
         @Schema(example = "[email protected]")
         public String emailAddress;
+        @Schema(example = "123")
+        public String externalId;

Review Comment:
   I think more than 2 API should retrieve the external id as well. It should 
be retrieved in all cases (where it makes sense). Like: GetClientsResponse



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to