adamsaghy commented on code in PR #2783:
URL: https://github.com/apache/fineract/pull/2783#discussion_r1039786406
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/client/ClientEntityImportHandler.java:
##########
@@ -141,7 +143,7 @@ private ClientData readClient(final Workbook workbook,
final Row row, final Stri
ClientNonPersonData clientNonPersonData =
ClientNonPersonData.importInstance(incorporationNo, incorporationTill, remarks,
mainBusinessId, constitutionId, locale, dateFormat);
- String externalId =
ImportHandlerUtils.readAsString(ClientEntityConstants.EXTERNAL_ID_COL, row);
+ ExternalId externalId =
ExternalIdFactory.produce(ImportHandlerUtils.readAsString(ClientEntityConstants.EXTERNAL_ID_COL,
row));
Review Comment:
Would it make more sense to use ExternalIdFactory.create()? it would auto
generate one if the configuration is enabled and value was not provided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
