adamsaghy commented on code in PR #2783:
URL: https://github.com/apache/fineract/pull/2783#discussion_r1039793234


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java:
##########
@@ -293,7 +297,7 @@ public static ClientData template(final Long officeId, 
final LocalDate joinedDat
         final String lastname = null;
         final String fullname = null;
         final String displayName = null;
-        final String externalId = null;
+        final ExternalId externalId = null;

Review Comment:
   ExternalId type object cannot be allowed to be null! Use `ExternalId.empty()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to