galovics commented on code in PR #2897:
URL: https://github.com/apache/fineract/pull/2897#discussion_r1081272455
##########
fineract-provider/src/main/java/org/apache/fineract/cob/domain/LoanAccountLock.java:
##########
@@ -57,10 +60,14 @@ public class LoanAccountLock {
@Column(name = "stacktrace")
private String stacktrace;
+ @Column(name = "lock_placed_on_cob_business_date", nullable = false)
+ private LocalDate lockPlacedOnCobBusinessDate;
Review Comment:
Can't we just call it lockPlacedOnBusinessDate and use it as
DateUtils.getBusinessDate()?
##########
fineract-provider/src/main/java/org/apache/fineract/cob/loan/StayedLockedLoansTasklet.java:
##########
@@ -33,16 +39,25 @@
@RequiredArgsConstructor
public class StayedLockedLoansTasklet implements Tasklet {
- private final LoanAccountLockRepository loanAccountLockRepository;
private final BusinessEventNotifierService businessEventNotifierService;
+ private final LoanRepository loanRepository;
@Override
public RepeatStatus execute(StepContribution contribution, ChunkContext
chunkContext) throws Exception {
- List<LoanAccountLock> loanAccountLocks =
loanAccountLockRepository.findAll();
- if (!loanAccountLocks.isEmpty()) {
- List<Long> loanIds =
loanAccountLocks.stream().map(LoanAccountLock::getLoanId).toList();
- businessEventNotifierService.notifyPostBusinessEvent(new
LoanAccountsStayedLockedBusinessEvent(loanIds));
+ LoanAccountsStayedLockedBusinessEvent.Data lockedLoanAccounts =
buildLoanAccountData();
+ if (!lockedLoanAccounts.getLoanAccounts().getLoanAccounts().isEmpty())
{
Review Comment:
why the double getLoanAccounts()?
##########
fineract-provider/src/main/resources/db/changelog/tenant/parts/0086_add_cob_business_date_to_loan_account_locks.xml:
##########
@@ -0,0 +1,32 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+
xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.3.xsd";>
+ <changeSet author="fineract" id="1" context="mysql">
+ <addColumn tableName="m_loan_account_locks">
+ <column name="lock_placed_on_cob_business_date" type="DATE">
+ <constraints nullable="false"/>
Review Comment:
Let's give it a default value in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
