adamsaghy commented on code in PR #2897:
URL: https://github.com/apache/fineract/pull/2897#discussion_r1081295733
##########
fineract-provider/src/main/java/org/apache/fineract/cob/domain/LoanAccountLock.java:
##########
@@ -57,10 +60,14 @@ public class LoanAccountLock {
@Column(name = "stacktrace")
private String stacktrace;
+ @Column(name = "lock_placed_on_cob_business_date", nullable = false)
+ private LocalDate lockPlacedOnCobBusinessDate;
Review Comment:
Just to give a 3rd opinion: "lock_placed_on" makes more sense to me. We
should not put business logic into db column naming (i know, i know...many
cases its already there but...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
