adamsaghy commented on code in PR #2908:
URL: https://github.com/apache/fineract/pull/2908#discussion_r1086478278
##########
fineract-provider/src/main/java/org/apache/fineract/notification/service/NotificationDomainServiceImpl.java:
##########
@@ -345,4 +347,19 @@ private Set<Long> getNotifiableUserIds(Long officeId,
String permission) {
Collection<AppUser> usersWithPermission = users.stream().filter(aU ->
aU.hasAnyPermission(permission, "ALL_FUNCTIONS")).toList();
return
usersWithPermission.stream().map(AppUser::getId).collect(toSet());
}
+
+ private static class LoanStatusChangedListener implements
BusinessEventListener<LoanStatusChangedBusinessEvent> {
Review Comment:
Please move this logic into LoanWritePlatformServiceJpaRepositoryImpl or
create a new service which will take care of the logic. I reckon the
NotificationDomainService is not the proper place!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
