josehernandezfintecheandomx commented on code in PR #2908:
URL: https://github.com/apache/fineract/pull/2908#discussion_r1086622296
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -3969,14 +3990,13 @@ public ChangedTransactionDetail close(final JsonCommand
command, final LoanLifec
final Money totalLoanOverpayment = calculateTotalOverpayment();
if (totalLoanOverpayment.isGreaterThanZero() &&
getInArrearsTolerance().isGreaterThanOrEqualTo(totalLoanOverpayment)) {
// TODO - KW - technically should set somewhere that this loan
- // has
- // 'overpaid' amount
+ // has 'overpaid' amount
+ this.closedOnDate = closureDate;
Review Comment:
I needed to move the set of the `closedOnDate` value before the Life cycle
machine method call because when the event listener was called It was in null
at that moment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
