adamsaghy commented on PR #3029: URL: https://github.com/apache/fineract/pull/3029#issuecomment-1460740760
Unfortunately we cannot modify already pushed changes. Anyone who has already executed the liquibase will get validation error if we are changing something like this :/ Usually the proper way is creating a brand new changeset which modify the existing (if possible, by not losing or modifying the data) or creating new columns and do the changes to use the old if set and use the new if set (backward compability). Kindly asking you to create a bug ticket for this in Fineract jira (@bharathc27 can help you with that) and try to share some details why it was failing for you. Under that ticket we can investigate this issue and discuss the details of the fix. your PR is a good starting point however these fixes should be assigned to a Fineract ticket and also if we are touching this fields we might wanna even go further and enhance them to support Timestamp with timezone for postgres and datetime for mysql and offsetdatetime at JPA side so we can assure a valid UTC got stored in it as it was doing with many other entities (like: Loan) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
