vidakovic commented on PR #3029:
URL: https://github.com/apache/fineract/pull/3029#issuecomment-1467693278

   Also: could you please name the PR according the general pattern we agreed 
on? Just having the Jira ticket number leaves you here a bit in the dark if not 
opening the Jira ticket itself. Please use following format (correct one for 
this PR): "Fineract-1780: Introduce Lombok to workingdays module"... first I 
thought this is about Liquibase (because of above discussion you had)... but in 
fact it's a simple Lombok related change... so maybe we can safe this one.
   Also: please squash your commits into one.
   Thanks again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to