vidakovic commented on code in PR #3041:
URL: https://github.com/apache/fineract/pull/3041#discussion_r1135112419
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/persistence/ExtendedJpaTransactionManager.java:
##########
@@ -29,6 +32,8 @@
public class ExtendedJpaTransactionManager extends JpaTransactionManager {
Review Comment:
Do we really need this? Can't this be accomplished with
https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/transaction/event/TransactionalEventListener.html
(aka transaction bound events)? From a first look at this I'd say yes... if
you want to keep those custom lifecycle callbacks then you just need to write a
transaction event listener and do pretty much the same you do here in the
extended transaction manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
