vidakovic commented on code in PR #3041:
URL: https://github.com/apache/fineract/pull/3041#discussion_r1135117369
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/domain/GlobalConfigurationRepositoryWrapper.java:
##########
@@ -37,6 +41,7 @@ public GlobalConfigurationRepositoryWrapper(final
GlobalConfigurationRepository
this.repository = repository;
}
+ @Cacheable(value = "configByName", key =
"T(org.apache.fineract.infrastructure.core.service.ThreadLocalContextUtil).getTenant().getTenantIdentifier().concat(#propertyName)")
Review Comment:
Just in general: I would try to eliminate this service all together... as
can be seen with this requirement to add caching... this thing is just getting
in the way and it's not really dev-ops friendly (as you need a database in the
first place to be able to do your configuration... instead of simple files)...
just saying it again: I think reloadable configurations are a solved problem in
Spring/Boot... my 2 cents here: this service is creating more head-aches than
it provides solutions. But maybe a discussion for another day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
