adamsaghy commented on code in PR #3195:
URL: https://github.com/apache/fineract/pull/3195#discussion_r1201952712
##########
fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersReadServiceImpl.java:
##########
@@ -37,8 +39,8 @@ public class ExternalAssetOwnersReadServiceImpl implements
ExternalAssetOwnersRe
@Override
public List<ExternalTransferData> retrieveTransferData(Long loanId, String
externalLoanId, String transferExternalId) {
- List<ExternalAssetOwnerTransfer> result =
externalAssetOwnerTransferRepository.findAllByIncomingId(loanId, externalLoanId,
- transferExternalId);
+ List<ExternalAssetOwnerTransfer> result =
externalAssetOwnerTransferRepository.findAllByIncomingId(loanId,
+ Objects.isNull(externalLoanId) ? null : new
ExternalId(externalLoanId), new ExternalId(transferExternalId));
Review Comment:
this should be already ExternalId type by this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
