adamsaghy commented on code in PR #3195: URL: https://github.com/apache/fineract/pull/3195#discussion_r1201967015
########## fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersWriteServiceImpl.java: ########## @@ -0,0 +1,229 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.investor.service; + +import com.google.gson.JsonElement; +import com.google.gson.reflect.TypeToken; +import java.lang.reflect.Type; +import java.time.LocalDate; +import java.util.Arrays; +import java.util.HashSet; +import java.util.Map; +import java.util.Objects; +import java.util.Optional; +import java.util.Set; +import lombok.RequiredArgsConstructor; +import org.apache.fineract.infrastructure.core.domain.ExternalId; +import org.apache.fineract.infrastructure.core.serialization.FromJsonHelper; +import org.apache.fineract.infrastructure.core.serialization.JsonParserHelper; +import org.apache.fineract.infrastructure.core.service.ThreadLocalContextUtil; +import org.apache.fineract.investor.data.ExternalTransferChangedData; +import org.apache.fineract.investor.data.ExternalTransferRequestParameters; +import org.apache.fineract.investor.data.ExternalTransferResponseData; +import org.apache.fineract.investor.data.ExternalTransferStatus; +import org.apache.fineract.investor.domain.ExternalAssetOwner; +import org.apache.fineract.investor.domain.ExternalAssetOwnerRepository; +import org.apache.fineract.investor.domain.ExternalAssetOwnerTransfer; +import org.apache.fineract.investor.domain.ExternalAssetOwnerTransferRepository; +import org.apache.fineract.investor.exception.ExternalAssetOwnerInitiateTransferException; +import org.apache.fineract.portfolio.loanaccount.service.LoanReadPlatformServiceCommon; +import org.springframework.stereotype.Service; +import org.springframework.transaction.annotation.Transactional; + +@Service +@RequiredArgsConstructor +public class ExternalAssetOwnersWriteServiceImpl implements ExternalAssetOwnersWriteService { + + private final ExternalAssetOwnerTransferRepository externalAssetOwnerTransferRepository; + private final ExternalAssetOwnerRepository externalAssetOwnerRepository; + private final FromJsonHelper fromApiJsonHelper; + private final LoanReadPlatformServiceCommon loanReadPlatformService; + + @Override + @Transactional + public ExternalTransferResponseData saleLoanByLoanId(Long loanId, String apiRequestBodyAsJson) { + ExternalAssetOwnerTransfer externalAssetOwnerTransfer = parseJson(loanId, apiRequestBodyAsJson, null); + validateSale(externalAssetOwnerTransfer); + ExternalAssetOwnerTransfer savedExternalAssetOwnerTransfer = externalAssetOwnerTransferRepository.save(externalAssetOwnerTransfer); + return buildResponseData(savedExternalAssetOwnerTransfer, apiRequestBodyAsJson); + } + + @Override + @Transactional + public ExternalTransferResponseData saleLoanByExternalLoanId(ExternalId externalLoanId, String apiRequestBodyAsJson) { + ExternalAssetOwnerTransfer externalAssetOwnerTransfer = parseJson(null, apiRequestBodyAsJson, externalLoanId); + validateSale(externalAssetOwnerTransfer); + ExternalAssetOwnerTransfer savedExternalAssetOwnerTransfer = externalAssetOwnerTransferRepository.save(externalAssetOwnerTransfer); + return buildResponseData(savedExternalAssetOwnerTransfer, apiRequestBodyAsJson); + } + + @Override + @Transactional + public ExternalTransferResponseData buyBackLoanByLoanId(Long loanId, String apiRequestBodyAsJson) { + ExternalAssetOwnerTransfer externalAssetOwnerTransfer = parseJson(loanId, apiRequestBodyAsJson, null); + validateBuyBack(externalAssetOwnerTransfer); + ExternalAssetOwnerTransfer savedExternalAssetOwnerTransfer = externalAssetOwnerTransferRepository.save(externalAssetOwnerTransfer); + return buildResponseData(savedExternalAssetOwnerTransfer, apiRequestBodyAsJson); + } + + @Override + @Transactional + public ExternalTransferResponseData buyBackLoanByExternalLoanId(ExternalId externalLoanId, String apiRequestBodyAsJson) { + ExternalAssetOwnerTransfer externalAssetOwnerTransfer = parseJson(null, apiRequestBodyAsJson, externalLoanId); + validateBuyBack(externalAssetOwnerTransfer); + ExternalAssetOwnerTransfer savedExternalAssetOwnerTransfer = externalAssetOwnerTransferRepository.save(externalAssetOwnerTransfer); + return buildResponseData(savedExternalAssetOwnerTransfer, apiRequestBodyAsJson); + } + + private ExternalTransferResponseData buildResponseData(ExternalAssetOwnerTransfer savedExternalAssetOwnerTransfer, + String apiRequestBodyAsJson) { + final JsonElement json = fromApiJsonHelper.parse(apiRequestBodyAsJson); + ExternalTransferResponseData responseData = new ExternalTransferResponseData(); + responseData.setResourceId(savedExternalAssetOwnerTransfer.getId()); + responseData.setResourceExternalId(savedExternalAssetOwnerTransfer.getExternalId().getValue()); + responseData.setSubResourceId(savedExternalAssetOwnerTransfer.getLoanId()); + responseData.setSubResourceExternalId(Objects.isNull(savedExternalAssetOwnerTransfer.getExternalLoanId()) ? null + : savedExternalAssetOwnerTransfer.getExternalLoanId().getValue()); + ExternalTransferChangedData changedData = new ExternalTransferChangedData(); + changedData.setSettlementDate(savedExternalAssetOwnerTransfer.getSettlementDate()); + changedData.setOwnerExternalId(savedExternalAssetOwnerTransfer.getOwner().getExternalId().getValue()); + changedData.setTransferExternalId(savedExternalAssetOwnerTransfer.getExternalId().getValue()); + changedData.setPurchasePriceRatio(savedExternalAssetOwnerTransfer.getPurchasePriceRatio()); + responseData.setChanges(changedData); + responseData.setDateformat(fromApiJsonHelper.extractStringNamed(ExternalTransferRequestParameters.DATEFORMAT, json)); + responseData.setLocale(fromApiJsonHelper.extractStringNamed(ExternalTransferRequestParameters.LOCALE, json)); + return responseData; + } + + private void validateSale(ExternalAssetOwnerTransfer externalAssetOwnerTransfer) { + validateSettlementDate(externalAssetOwnerTransfer); + validateTransferStatusForSale(externalAssetOwnerTransfer); + validateLoanStatus(externalAssetOwnerTransfer); + } + + private void validateBuyBack(ExternalAssetOwnerTransfer externalAssetOwnerTransfer) { + validateSettlementDate(externalAssetOwnerTransfer); + validateTransferStatusForBuyBack(externalAssetOwnerTransfer); + } + + private void validateSettlementDate(ExternalAssetOwnerTransfer externalAssetOwnerTransfer) { + if (externalAssetOwnerTransfer.getSettlementDate().isBefore(ThreadLocalContextUtil.getBusinessDate())) { + throw new ExternalAssetOwnerInitiateTransferException("Settlement date cannot be in the past"); + } + } + + private void validateLoanStatus(ExternalAssetOwnerTransfer externalAssetOwnerTransfer) { + if (!Objects.isNull(externalAssetOwnerTransfer.getLoanId()) + && !loanReadPlatformService.isLoanTransferable(externalAssetOwnerTransfer.getLoanId())) { + throw new ExternalAssetOwnerInitiateTransferException("Loan is not in active status"); + } else if (!Objects.isNull(externalAssetOwnerTransfer.getExternalLoanId()) + && loanReadPlatformService.isLoanTransferable(externalAssetOwnerTransfer.getExternalLoanId())) { + throw new ExternalAssetOwnerInitiateTransferException("Loan is not in active status"); + } + } + + private void validateTransferStatusForSale(ExternalAssetOwnerTransfer externalAssetOwnerTransfer) { + Optional<ExternalAssetOwnerTransfer> latestTransferOptional = externalAssetOwnerTransferRepository + .findLatestByLoanIdOrExternalLoanId(externalAssetOwnerTransfer.getLoanId(), externalAssetOwnerTransfer.getExternalLoanId()); + if (latestTransferOptional.isPresent()) { + ExternalAssetOwnerTransfer latestTransfer = latestTransferOptional.get(); + ExternalTransferStatus latestTransferStatus = ExternalTransferStatus.valueOf(latestTransfer.getStatus()); + if (latestTransferStatus.equals(ExternalTransferStatus.PENDING)) { + throw new ExternalAssetOwnerInitiateTransferException( + "External asset owner transfer is already in PENDING state for this loan."); + } else if (latestTransferStatus.equals(ExternalTransferStatus.ACTIVE)) { + throw new ExternalAssetOwnerInitiateTransferException( + "This loan cannot be sold, because it is owned by an external asset owner."); + } + } + } + + private void validateTransferStatusForBuyBack(ExternalAssetOwnerTransfer externalAssetOwnerTransfer) { + Optional<ExternalAssetOwnerTransfer> latestTransferOptional = externalAssetOwnerTransferRepository + .findLatestByLoanIdOrExternalLoanId(externalAssetOwnerTransfer.getLoanId(), externalAssetOwnerTransfer.getExternalLoanId()); + if (latestTransferOptional.isEmpty()) { + throw new ExternalAssetOwnerInitiateTransferException( + "This loan cannot be bought back, because it is not owned by an external asset owner"); + } else { + ExternalAssetOwnerTransfer latestTransfer = latestTransferOptional.get(); + ExternalTransferStatus latestTransferStatus = ExternalTransferStatus.valueOf(latestTransfer.getStatus()); + if (latestTransferStatus.equals(ExternalTransferStatus.BUYBACK)) { + throw new ExternalAssetOwnerInitiateTransferException( + "External asset owner transfer is already in BUYBACK state for this loan."); + } + } + } + + private ExternalAssetOwnerTransfer parseJson(Long loanId, String apiRequestBodyAsJson, ExternalId externalLoanId) { + ExternalAssetOwnerTransfer externalAssetOwnerTransfer = new ExternalAssetOwnerTransfer(); + + validateRequestBody(apiRequestBodyAsJson); + final JsonElement json = fromApiJsonHelper.parse(apiRequestBodyAsJson); + + ExternalAssetOwner owner = getOwner(json); + externalAssetOwnerTransfer.setOwnerId(owner.getId()); + externalAssetOwnerTransfer.setOwner(owner); + externalAssetOwnerTransfer.setExternalId(getTransferExternalIdFromJson(json)); + externalAssetOwnerTransfer.setStatus(ExternalTransferStatus.PENDING.name()); Review Comment: Hardcoded PENDING sounds wrong to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
