abraham-menyhart commented on code in PR #3205:
URL: https://github.com/apache/fineract/pull/3205#discussion_r1206876919
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -265,37 +273,37 @@ private void extractResults(SqlRowSet rowSet, String[]
resultColumnNames, List<J
}
@NotNull
- private SqlRowSet callFilteredMysql(String sql, String valueFilter, String
filterColumnType) {
+ private SqlRowSet callFilteredMysql(String sql, Object valueFilter, String
filterColumnType) {
Object finalValueFilter = valueFilter;
SqlRowSet rowSet;
if (BIT_TYPE.equalsIgnoreCase(filterColumnType)) {
int[] argType = new int[1];
argType[0] = Types.BIT;
- finalValueFilter =
BooleanUtils.toString(BooleanUtils.toBooleanObject(valueFilter), "1", "0",
"null");
+ finalValueFilter =
BooleanUtils.toString(BooleanUtils.toBooleanObject(valueFilter.toString()),
"1", "0", "null");
Review Comment:
I was waiting for this comment, I totally agree with you, and I'm already
thinking about how to fix it!
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -265,37 +273,37 @@ private void extractResults(SqlRowSet rowSet, String[]
resultColumnNames, List<J
}
@NotNull
- private SqlRowSet callFilteredMysql(String sql, String valueFilter, String
filterColumnType) {
+ private SqlRowSet callFilteredMysql(String sql, Object valueFilter, String
filterColumnType) {
Object finalValueFilter = valueFilter;
SqlRowSet rowSet;
if (BIT_TYPE.equalsIgnoreCase(filterColumnType)) {
int[] argType = new int[1];
argType[0] = Types.BIT;
- finalValueFilter =
BooleanUtils.toString(BooleanUtils.toBooleanObject(valueFilter), "1", "0",
"null");
+ finalValueFilter =
BooleanUtils.toString(BooleanUtils.toBooleanObject(valueFilter.toString()),
"1", "0", "null");
Review Comment:
I was waiting for this comment! I totally agree with you, and I'm already
thinking about how to fix it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
