abraham-menyhart commented on code in PR #3205: URL: https://github.com/apache/fineract/pull/3205#discussion_r1206872679
########## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java: ########## @@ -19,6 +19,8 @@ package org.apache.fineract.infrastructure.dataqueries.service; import static java.util.Arrays.asList; +import static java.util.Locale.ENGLISH; +import static org.apache.commons.lang3.time.DateFormatUtils.ISO_8601_EXTENDED_DATE_FORMAT; Review Comment: I would, but the input of the validateColumn method is a string... And I didn't want to refactor the validateColumn method to accept DateTimeFormatter. You ask too much @adamsaghy ! :moneybag: But I'll see want I can do :wink: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
