adamsaghy commented on code in PR #3269:
URL: https://github.com/apache/fineract/pull/3269#discussion_r1238585805
##########
fineract-investor/src/main/java/org/apache/fineract/investor/domain/ExternalAssetOwnerTransferRepository.java:
##########
@@ -47,7 +47,7 @@ public interface ExternalAssetOwnerTransferRepository
@Query("select m.ownerTransfer.owner from
ExternalAssetOwnerTransferLoanMapping m where m.loanId = :loanId")
Optional<ExternalAssetOwner> findActiveOwnerByLoanId(@Param("loanId") Long
loanId);
- @Query("SELECT t FROM ExternalAssetOwnerTransfer t WHERE t.loanId =
:loanId AND t.effectiveDateTo > :effectiveDate")
+ @Query("SELECT t FROM ExternalAssetOwnerTransfer t WHERE t.loanId =
:loanId AND t.effectiveDateTo > :effectiveDate order by t.id desc")
List<ExternalAssetOwnerTransfer> findEffectiveTransfers(@Param("loanId")
Long loanId, @Param("effectiveDate") LocalDate effectiveDate);
Review Comment:
you might wanna reflect the ordering in the method name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
