b0c1 commented on code in PR #3269:
URL: https://github.com/apache/fineract/pull/3269#discussion_r1238659489


##########
fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersReadServiceImpl.java:
##########
@@ -120,6 +120,13 @@ public ExternalTransferData 
retrieveFirstTransferByExternalId(ExternalId externa
                 .orElseThrow(() -> new 
ExternalAssetOwnerTransferNotFoundException(externalTransferId));
     }
 
+    @Override
+    public Long retrieveFirstTransferIdByExternalId(ExternalId 
externalTransferId) {
+        return 
externalAssetOwnerTransferRepository.findFirstByExternalIdOrderByIdAsc(externalTransferId)

Review Comment:
   I think it's irrelevant because transferExternal id will identify only one 
transfer (or two if already cancelled), but Ofc we can get the latest...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to