adamsaghy commented on code in PR #3305:
URL: https://github.com/apache/fineract/pull/3305#discussion_r1262367474
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/LoanProductRepository.java:
##########
@@ -33,4 +33,6 @@ public interface LoanProductRepository extends
JpaRepository<LoanProduct, Long>,
Long countByDelinquencyBucket(DelinquencyBucket delinquencyBucket);
List<LoanProduct> findByDelinquencyBucketNotNull();
+
+ LoanProduct findByExternalId(String externalId);
Review Comment:
Please use the ExternalId as type
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/exception/LoanProductNotFoundException.java:
##########
@@ -30,6 +30,10 @@ public LoanProductNotFoundException(final Long id) {
super("error.msg.loanproduct.id.invalid", "Loan product with
identifier " + id + " does not exist", id);
}
+ public LoanProductNotFoundException(final String externalId) {
Review Comment:
Please use the ExternalId as type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
