adamsaghy commented on code in PR #3305:
URL: https://github.com/apache/fineract/pull/3305#discussion_r1262376007
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/loans/LoanProductTestBuilder.java:
##########
@@ -76,6 +77,7 @@ public class LoanProductTestBuilder {
private String nameOfLoanProduct =
Utils.uniqueRandomStringGenerator("LOAN_PRODUCT_", 6);
private String shortName = Utils.uniqueRandomStringGenerator("", 4);
+ private String externalId = UUID.randomUUID().toString();
Review Comment:
I reckon, if it is not explicitly provided, it is better to leave it as null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
