adamsaghy commented on code in PR #3318:
URL: https://github.com/apache/fineract/pull/3318#discussion_r1270594955
##########
fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersWriteServiceImpl.java:
##########
@@ -99,6 +101,8 @@ public CommandProcessingResult
buybackLoanByLoanId(JsonCommand command) {
validateBuybackRequestBody(command.json());
Long loanId = command.getLoanId();
validateLoan(loanId);
+ Integer loanStatus = fetchLoanStatus(loanId);
+ validateLoanStatus(loanStatus);
Review Comment:
It was not mistake to not checking the loan status for buyback! We dont
wanna validate it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
