adamsaghy commented on code in PR #3318: URL: https://github.com/apache/fineract/pull/3318#discussion_r1270617878
########## fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersWriteServiceImpl.java: ########## @@ -256,7 +259,11 @@ private void validateSettlementDate(LocalDate settlementDate) { } private void validateLoanStatus(LoanIdAndExternalIdAndStatus entity) { - if (!NON_CLOSED_LOAN_STATUSES.contains(LoanStatus.fromInt(entity.getLoanStatus()))) { + validateLoanStatus(entity.getLoanStatus()); + } + + private void validateLoanStatus(Integer loanStatus) { Review Comment: Probably does can be removed as we dont need loan status check for buyback -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org