vidakovic commented on code in PR #3321:
URL: https://github.com/apache/fineract/pull/3321#discussion_r1281111751
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseTypeResolver.java:
##########
@@ -58,10 +58,10 @@ public DatabaseType databaseType() {
}
public boolean isPostgreSQL() {
- return DatabaseType.POSTGRESQL.equals(currentDatabaseType.get());
+ return DatabaseType.POSTGRESQL == currentDatabaseType.get();
Review Comment:
I would dump these functions too (see my previous comment on DatabaseType).
What are we saving here? Again, let's say we add support for 10 more
databases...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
