marta-jankovics commented on code in PR #3321:
URL: https://github.com/apache/fineract/pull/3321#discussion_r1307310298
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -1940,8 +2047,8 @@ private String validateDatatableRegistered(String
datatable) {
private boolean isRegisteredDataTable(final String datatable) {
final String sql = "SELECT COUNT(application_table_name) FROM " +
TABLE_REGISTERED_TABLE + " WHERE registered_table_name = ?";
- final int count = jdbcTemplate.queryForObject(sql, Integer.class,
datatable);
- return count > 0;
+ final Integer count = jdbcTemplate.queryForObject(sql, Integer.class,
datatable);
Review Comment:
for me it was a checkstyle warning, if it can not return null, it is fine,
but lets be safe
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -1890,7 +1997,7 @@ public boolean
isDatatableAttachedToEntityDatatableCheck(final String datatableN
+ " JOIN m_entity_datatable_check edc ON
edc.x_registered_table_name = xrt.registered_table_name"
+ " WHERE edc.x_registered_table_name = '" + datatableName +
"'";
final Long count = this.jdbcTemplate.queryForObject(sql, Long.class);
- return count > 0;
+ return count != null && count > 0;
Review Comment:
for me it was a checkstyle warning, if it can not return null, it is fine,
but lets be safe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
