adamsaghy commented on code in PR #3350:
URL: https://github.com/apache/fineract/pull/3350#discussion_r1291264723
##########
fineract-investor/src/main/java/org/apache/fineract/investor/api/ExternalAssetOwnersApiResourceSwagger.java:
##########
@@ -152,4 +152,57 @@ static final class ExternalAssetOwnerTransferChangesData {
public String purchasePriceRatio;
}
}
+
+ @Schema(description = "GetExternalAssetOwnerSearchRequest")
+ public static final class GetExternalAssetOwnerSearchRequest {
+
+ private GetExternalAssetOwnerSearchRequest() {}
+
+ @Schema(example = "2023-05-23")
+ public String settlementFromDate;
+
+ @Schema(example = "2023-06-23")
+ public String settlementToDate;
+
+ @Schema(example = "2023-05-23")
+ public String effectiveFromDate;
+
+ @Schema(example = "2023-06-23")
+ public String effectiveToDate;
+
+ @Schema(example = "1234567890987654321abc")
+ public String text;
+ }
+
+ @Schema(description = "GetSearchExternalAssetOwnerTransferResponse")
Review Comment:
We dont need this. Swagger can automatically generate this. See
`ExternalAssetOwnersApiResource.getTransfers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
