adamsaghy commented on code in PR #3350:
URL: https://github.com/apache/fineract/pull/3350#discussion_r1291270019
##########
fineract-investor/src/main/java/org/apache/fineract/investor/api/ExternalAssetOwnersApiResourceSwagger.java:
##########
@@ -28,59 +28,59 @@ final class ExternalAssetOwnersApiResourceSwagger {
private ExternalAssetOwnersApiResourceSwagger() {}
- @Schema(description = "ExternalTransferResponse")
- public static final class GetExternalTransferResponse {
+ static final class GetExternalTransferPageItems {
- private GetExternalTransferResponse() {}
+ private GetExternalTransferPageItems() {}
- static final class GetExternalTransferPageItems {
+ static final class GetExternalTransferOwner {
- private GetExternalTransferPageItems() {}
+ private GetExternalTransferOwner() {}
- static final class GetExternalTransferOwner {
+ @Schema(example = "e1156fbe-38bb-42f8-b491-fca02075f40e")
+ public String externalId;
+ }
- private GetExternalTransferOwner() {}
+ static final class GetExternalTransferLoan {
- @Schema(example = "e1156fbe-38bb-42f8-b491-fca02075f40e")
- public String externalId;
- }
+ private GetExternalTransferLoan() {}
- static final class GetExternalTransferLoan {
+ @Schema(example = "1")
+ public Long loanId;
- private GetExternalTransferLoan() {}
+ @Schema(example = "e1156fbe-38bb-42f8-b491-fca02075f40e")
+ public String externalId;
+ }
- @Schema(example = "1")
- public Long loanId;
+ @Schema(example = "1")
+ public Long transferId;
- @Schema(example = "e1156fbe-38bb-42f8-b491-fca02075f40e")
- public String externalId;
- }
+ public GetExternalTransferOwner owner;
- @Schema(example = "1")
- public Long transferId;
+ public GetExternalTransferLoan loan;
- public GetExternalTransferOwner owner;
+ @Schema(example = "e1156fbe-38bb-42f8-b491-fca02075f40e")
+ public String transferExternalId;
- public GetExternalTransferLoan loan;
+ @Schema(example = "1")
+ public String purchasePriceRatio;
- @Schema(example = "e1156fbe-38bb-42f8-b491-fca02075f40e")
- public String transferExternalId;
+ @Schema(example = "[2023, 5, 23]")
+ public LocalDate settlementDate;
- @Schema(example = "1")
- public String purchasePriceRatio;
+ @Schema(example = "PENDING")
+ public ExternalTransferStatus status;
- @Schema(example = "[2023, 5, 23]")
- public LocalDate settlementDate;
+ @Schema(example = "[2023, 5, 1]")
+ public LocalDate effectiveFrom;
- @Schema(example = "PENDING")
- public ExternalTransferStatus status;
+ @Schema(example = "[2023, 5, 23]")
+ public LocalDate effectiveTo;
+ }
- @Schema(example = "[2023, 5, 1]")
- public LocalDate effectiveFrom;
+ @Schema(description = "ExternalTransferResponse")
Review Comment:
you might wanna revert this rearrangement changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
