adamsaghy commented on code in PR #3366:
URL: https://github.com/apache/fineract/pull/3366#discussion_r1301312705
##########
fineract-core/src/main/java/org/apache/fineract/accounting/common/AccountingConstants.java:
##########
@@ -318,22 +307,17 @@ public String getValue() {
public enum SavingProductAccountingDataParams {
- SAVINGS_REFERENCE("savingsReferenceAccount"), //
- SAVINGS_CONTROL("savingsControlAccount"), //
- INCOME_FROM_FEES("incomeFromFeeAccount"), //
- INCOME_FROM_PENALTIES("incomeFromPenaltyAccount"), //
- INTEREST_ON_SAVINGS("interestOnSavingsAccount"), //
- PAYMENT_TYPE("paymentType"), //
- FUND_SOURCE("fundSourceAccount"), //
- TRANSFERS_SUSPENSE("transfersInSuspenseAccount"), //
- PENALTY_INCOME_ACCOUNT_MAPPING("penaltyToIncomeAccountMappings"), //
- CHARGE_ID("charge"), //
- INCOME_ACCOUNT_ID("incomeAccount"), //
- OVERDRAFT_PORTFOLIO_CONTROL("overdraftPortfolioControl"), //
- INCOME_FROM_INTEREST("incomeFromInterest"), //
- LOSSES_WRITTEN_OFF("writeOffAccount"), //
- ESCHEAT_LIABILITY("escheatLiabilityAccount"); //
-
+ SAVINGS_REFERENCE("savingsReferenceAccount"),
SAVINGS_CONTROL("savingsControlAccount"), INCOME_FROM_FEES(
Review Comment:
Please undo this. The ordering was intentional.
##########
fineract-core/src/main/java/org/apache/fineract/accounting/common/AccountingConstants.java:
##########
@@ -352,13 +336,11 @@ public String getValue() {
public enum FinancialActivity {
- ASSET_TRANSFER(100, "assetTransfer", GLAccountType.ASSET), //
- LIABILITY_TRANSFER(200, "liabilityTransfer", GLAccountType.LIABILITY),
//
- CASH_AT_MAINVAULT(101, "cashAtMainVault", GLAccountType.ASSET), //
- CASH_AT_TELLER(102, "cashAtTeller", GLAccountType.ASSET), //
- OPENING_BALANCES_TRANSFER_CONTRA(300, "openingBalancesTransferContra",
GLAccountType.EQUITY), //
- ASSET_FUND_SOURCE(103, "fundSource", GLAccountType.ASSET), //
- PAYABLE_DIVIDENDS(201, "payableDividends", GLAccountType.LIABILITY); //
+ ASSET_TRANSFER(100, "assetTransfer", GLAccountType.ASSET),
LIABILITY_TRANSFER(200, "liabilityTransfer",
Review Comment:
Please undo this. The ordering was intentional.
##########
fineract-core/src/main/java/org/apache/fineract/accounting/common/AccountingConstants.java:
##########
@@ -470,10 +452,8 @@ public static CashAccountsForShares fromInt(final int i) {
***/
public enum SharesProductAccountingParams {
- SHARES_REFERENCE("shareReferenceId"), //
- SHARES_SUSPENSE("shareSuspenseId"), //
- INCOME_FROM_FEES("incomeFromFeeAccountId"), //
- SHARES_EQUITY("shareEquityId"); //
+ SHARES_REFERENCE("shareReferenceId"),
SHARES_SUSPENSE("shareSuspenseId"), INCOME_FROM_FEES("incomeFromFeeAccountId"),
SHARES_EQUITY(
Review Comment:
Please undo this. The ordering was intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
