adamsaghy commented on code in PR #3366:
URL: https://github.com/apache/fineract/pull/3366#discussion_r1301327076
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/RecurringDepositProductsApiResourceSwagger.java:
##########
@@ -343,88 +343,30 @@ private
GetRecurringDepositProductsProductIdInterestCompoundingPeriodType() {}
public String description;
}
- static final class
GetRecurringDepositProductsProductIdAccountingMappings {
-
- private GetRecurringDepositProductsProductIdAccountingMappings() {}
-
- static final class
GetRecurringDepositProductsProductIdSavingsReferenceAccount {
-
- private
GetRecurringDepositProductsProductIdSavingsReferenceAccount() {}
Review Comment:
I see, however if anyone was using the fineract-client to connect to
fineract, now it would be a breaking change for them. Please revert this
changes, and write a letter to dev mail list about the changes and the
reasoning and let them be aware this is breaking change for anyone who is using
fineract-client!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
