marta-jankovics commented on code in PR #3321:
URL: https://github.com/apache/fineract/pull/3321#discussion_r1307320706
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/search/service/SearchUtil.java:
##########
@@ -116,47 +116,75 @@ public static void extractJsonResult(@NotNull SqlRowSet
rowSet, @NotNull List<St
}
@NotNull
- public static List<String> validateToJdbcColumns(List<String> columns,
Map<String, ResultsetColumnHeaderData> columnHeaders,
- List<ApiParameterError> errors, boolean allowEmpty) {
- List<String> result = new ArrayList<>();
+ public static List<String> validateToJdbcColumnNames(List<String> columns,
Map<String, ResultsetColumnHeaderData> headersByName,
+ boolean allowEmpty) {
+ List<ResultsetColumnHeaderData> columnHeaders =
validateToJdbcColumns(columns, headersByName, allowEmpty);
+ return columnHeaders.stream().map(e -> e == null ? null :
e.getColumnName()).toList();
Review Comment:
columnHeaders can not be null, but the elements in it could be (in case
there are null values in the columns list and allowEmpty is true)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
