vidakovic commented on code in PR #3563:
URL: https://github.com/apache/fineract/pull/3563#discussion_r1442552683
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/JavaType.java:
##########
@@ -91,9 +91,7 @@ public enum JavaType {
OBJECT(Object.class), //
;
- public static final JavaType[] VALUES = values();
-
- private static final Map<Class<?>, JavaType> BY_TYPE =
Arrays.stream(VALUES).filter(e -> e.type != null)
+ private static final Map<Class<?>, JavaType> BY_TYPE =
Arrays.stream(values()).filter(e -> e.type != null)
Review Comment:
Reading this again... I might have commented a bit off topic here. Was still
in the "enum" thinking that was discussed earlier. This here is related to your
database mapping mechanics. Don`'t really have an opinion here other than: we
have technically 2 other database mapping mechanics in place (JPA, Spring Data
JDBC) that kind of - at least partially - do a lot of what you do here (type
mapping). It feels a bit redundant, but I have to admit that I didn't follow
exactly what requirements you had on your list and/or if there is maybe no
other way to it.
Again, not relevant for the release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
