vidakovic commented on code in PR #3563:
URL: https://github.com/apache/fineract/pull/3563#discussion_r1443754160
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/JdbcJavaType.java:
##########
@@ -136,11 +136,19 @@ public static JdbcJavaType getByTypeName(@NotNull
DatabaseType dialect, String n
for (JdbcJavaType type : values()) {
DialectType dialectType = type.getDialectType(dialect);
if (dialectType.getNameResolved().equals(name)) {
+ // NOTE: make MySQL systems happy aka TINYINT vs BOOLEAN issue!
Review Comment:
Have to do the release. Please propose a pull request if you see any need
for further improvement. As is works.
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/JdbcJavaType.java:
##########
@@ -136,11 +136,19 @@ public static JdbcJavaType getByTypeName(@NotNull
DatabaseType dialect, String n
for (JdbcJavaType type : values()) {
DialectType dialectType = type.getDialectType(dialect);
if (dialectType.getNameResolved().equals(name)) {
+ // NOTE: make MySQL systems happy aka TINYINT vs BOOLEAN issue!
+ if (type.canBooleanType(dialect)) {
+ return BOOLEAN;
+ }
return type;
}
if (dialectType.alterNames != null) {
for (String alterName : dialectType.alterNames) {
if (alterName.equals(name)) {
+ // NOTE: make MySQL systems happy aka TINYINT vs
BOOLEAN issue!
Review Comment:
Have to do the release. Please propose a pull request if you see any need
for further improvement. As is works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
