adamsaghy commented on code in PR #3752:
URL: https://github.com/apache/fineract/pull/3752#discussion_r1497657825
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccountingProcessorHelper.java:
##########
@@ -573,6 +574,27 @@ public void
createCashBasedJournalEntriesAndReversalsForSavingsTax(final Office
paymentTypeId, savingsId, transactionId, transactionDate,
amount, isReversal);
}
+ public void
createAccrualBasedJournalEntriesAndReversalsForSavingsTax(final Office office,
final String currencyCode,
+ final AccrualAccountsForSavings accountTypeToBeDebited, final
AccrualAccountsForSavings accountTypeToBeCredited,
+ final Long savingsProductId, final Long paymentTypeId, final Long
savingsId, final String transactionId,
+ final LocalDate transactionDate, final BigDecimal amount, final
Boolean isReversal, final List<TaxPaymentDTO> taxDetails) {
+
+ for (TaxPaymentDTO taxPaymentDTO : taxDetails) {
+ if (taxPaymentDTO.getAmount() != null) {
+ if (taxPaymentDTO.getCreditAccountId() == null) {
+
createCashBasedCreditJournalEntriesAndReversalsForSavings(office, currencyCode,
accountTypeToBeCredited.getValue(),
Review Comment:
An accrual based journal entry should not call cashbased once... Please
extract the logic into a common place if needed, but Cash based accounting and
Accrual based accounting should not be mixed together!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
