adamsaghy commented on code in PR #3752:
URL: https://github.com/apache/fineract/pull/3752#discussion_r1497664167
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/data/DepositProductDataValidator.java:
##########
@@ -115,7 +113,7 @@ public void validateForFixedDepositCreate(final String
json) {
final JsonElement element = this.fromApiJsonHelper.parse(json);
- validateDepositDetailForCreate(element, this.fromApiJsonHelper,
baseDataValidator);
+ validateDepositDetailForCreate(element, this.fromApiJsonHelper,
baseDataValidator, DepositAccountType.RECURRING_DEPOSIT);
Review Comment:
Validation of Fixed deposit is the method name but here you are providing
Recurring deposit. Why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
