adamsaghy commented on PR #3803: URL: https://github.com/apache/fineract/pull/3803#issuecomment-2006484376
> > Also please dont forget to add proper tests to cover your fix > > Do you mean to add some unit-tests to `isValidJson()` method or something else? Yes, You should test your fix by providing valid and invalid json and check whether it was handled and proper exception was raised. For that you can write unit test and/or integration test where you are testing one of the API and check what happens when invalid json body was provided. Regards Adam -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
