adamsaghy commented on code in PR #3803:
URL: https://github.com/apache/fineract/pull/3803#discussion_r1533451855
##########
fineract-core/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java:
##########
@@ -272,7 +272,12 @@ private void publishHookEvent(final String entityName,
final String actionName,
Type type = new TypeToken<Map<String, Object>>() {
}.getType();
- Map<String, Object> myMap = gson.fromJson(command.json(),
type);
+
Review Comment:
This is not correct... if the provided json is invalid, you should raise a
PlatformApiDataValidationException with some message of the nature of the
exception, like: "Invalid JSON was provided" or something like this. Feel free
to check how the above exception was raised in Fineract and with what
parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
