kjozsa opened a new pull request, #4005:
URL: https://github.com/apache/fineract/pull/4005

   ## Description
   
   Create loan and disburse loan was showing a different behavior (error) when 
a loan is created with advanced-payment-allocation-strategy. 
   
   Expected behavior: 403 with The date on which a loan is submitted cannot be 
after its expected disbursement date error as observed for other products with 
advanced-payment-allocation-strategy
   
   Behavior observed: Internal server error 500
   
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [X] Write the commit message as per 
https://github.com/apache/fineract/#pull-requests
   
   - [X] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   
   - [X] Create/update unit or integration tests for verifying the changes made.
   
   - [X] Follow coding conventions at 
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [X] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   
   - [X] Submission is not a "code dump".  (Large changes can be made "in 
repository" via a branch.  Ask on the developer mailing list for guidance, if 
required.)
   
   FYI our guidelines for code reviews are at 
https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to