galovics commented on code in PR #4048:
URL: https://github.com/apache/fineract/pull/4048#discussion_r1746661832
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/ProgressiveLoanScheduleGenerator.java:
##########
@@ -103,11 +104,15 @@ public LoanScheduleModel generate(final MathContext mc,
final LoanApplicationTer
prepareDisbursementsOnLoanApplicationTerms(loanApplicationTerms);
+ final ArrayList<DisbursementData> disbursementDataList = new
ArrayList<>(loanApplicationTerms.getDisbursementDatas());
+
disbursementDataList.sort(Comparator.comparing(DisbursementData::disbursementDate));
Review Comment:
Is disbursementDate a Date or a Timestamp? Is it possible that they get same
"disbursementDate"s? If so, we should fall back to a secondary sort attribute
like created date/etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
