galovics commented on code in PR #4048:
URL: https://github.com/apache/fineract/pull/4048#discussion_r1754269878
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/ProgressiveLoanScheduleGenerator.java:
##########
@@ -103,11 +104,15 @@ public LoanScheduleModel generate(final MathContext mc,
final LoanApplicationTer
prepareDisbursementsOnLoanApplicationTerms(loanApplicationTerms);
+ final ArrayList<DisbursementData> disbursementDataList = new
ArrayList<>(loanApplicationTerms.getDisbursementDatas());
+
disbursementDataList.sort(Comparator.comparing(DisbursementData::disbursementDate));
Review Comment:
noted, do you think we could create a test-case to cover the "same
disbursement day" behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
