galovics commented on code in PR #4172:
URL: https://github.com/apache/fineract/pull/4172#discussion_r1867127390
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/starter/LoanAccountConfiguration.java:
##########
@@ -389,13 +408,47 @@ public ReplayedTransactionBusinessEventService
replayedTransactionBusinessEventS
@Bean
@ConditionalOnMissingBean(LoanDownPaymentHandlerService.class)
public LoanDownPaymentHandlerService
loanDownPaymentHandlerService(LoanTransactionRepository
loanTransactionRepository,
- BusinessEventNotifierService businessEventNotifierService) {
- return new
LoanDownPaymentHandlerServiceImpl(loanTransactionRepository,
businessEventNotifierService);
+ BusinessEventNotifierService businessEventNotifierService,
+ LoanDownPaymentTransactionValidator
loanDownPaymentTransactionValidator, LoanScheduleService loanScheduleService,
+ LoanRefundService loanRefundService, LoanRefundValidator
loanRefundValidator) {
+ return new
LoanDownPaymentHandlerServiceImpl(loanTransactionRepository,
businessEventNotifierService,
+ loanDownPaymentTransactionValidator, loanScheduleService,
loanRefundService, loanRefundValidator);
}
@Bean
@ConditionalOnMissingBean(LoanDisbursementDetailsAssembler.class)
public LoanDisbursementDetailsAssembler
loanDisbursementDetailsAssembler(FromJsonHelper fromApiJsonHelper) {
return new LoanDisbursementDetailsAssembler(fromApiJsonHelper);
}
+
+ @Bean
+ @ConditionalOnMissingBean(LoanDisbursementService.class)
Review Comment:
Any reason these conditionals are not applied on the class themselves? That
way you don't need to write any Configuration impl.
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanChargeValidator.java:
##########
@@ -0,0 +1,101 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.portfolio.loanaccount.serialization;
+
+import java.time.LocalDate;
+import org.apache.fineract.infrastructure.core.service.DateUtils;
+import
org.apache.fineract.portfolio.charge.exception.LoanChargeCannotBeAddedException;
+import org.apache.fineract.portfolio.loanaccount.domain.Loan;
+import org.apache.fineract.portfolio.loanaccount.domain.LoanCharge;
+import org.apache.fineract.portfolio.loanaccount.domain.LoanTransaction;
+import
org.apache.fineract.portfolio.loanaccount.exception.InvalidLoanStateTransitionException;
+import
org.apache.fineract.portfolio.loanaccount.exception.LoanChargeRefundException;
+import org.springframework.stereotype.Component;
+
+@Component
+public final class LoanChargeValidator {
Review Comment:
Any reason this is final?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
