oleksii-novikov-onix commented on code in PR #4172:
URL: https://github.com/apache/fineract/pull/4172#discussion_r1869483883
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/starter/LoanAccountConfiguration.java:
##########
@@ -389,13 +408,47 @@ public ReplayedTransactionBusinessEventService
replayedTransactionBusinessEventS
@Bean
@ConditionalOnMissingBean(LoanDownPaymentHandlerService.class)
public LoanDownPaymentHandlerService
loanDownPaymentHandlerService(LoanTransactionRepository
loanTransactionRepository,
- BusinessEventNotifierService businessEventNotifierService) {
- return new
LoanDownPaymentHandlerServiceImpl(loanTransactionRepository,
businessEventNotifierService);
+ BusinessEventNotifierService businessEventNotifierService,
+ LoanDownPaymentTransactionValidator
loanDownPaymentTransactionValidator, LoanScheduleService loanScheduleService,
+ LoanRefundService loanRefundService, LoanRefundValidator
loanRefundValidator) {
+ return new
LoanDownPaymentHandlerServiceImpl(loanTransactionRepository,
businessEventNotifierService,
+ loanDownPaymentTransactionValidator, loanScheduleService,
loanRefundService, loanRefundValidator);
}
@Bean
@ConditionalOnMissingBean(LoanDisbursementDetailsAssembler.class)
public LoanDisbursementDetailsAssembler
loanDisbursementDetailsAssembler(FromJsonHelper fromApiJsonHelper) {
return new LoanDisbursementDetailsAssembler(fromApiJsonHelper);
}
+
+ @Bean
+ @ConditionalOnMissingBean(LoanDisbursementService.class)
Review Comment:
Sorry, I'm not sure I fully understand your question. Are you asking about
the reason for using @ConditionalOnMissingBean at all, or is there a different
way we could use it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
