adamsaghy commented on code in PR #4246:
URL: https://github.com/apache/fineract/pull/4246#discussion_r1907586557


##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransaction.java:
##########
@@ -458,6 +458,16 @@ public void reverse(final ExternalId reversalExternalId) {
         this.reversalExternalId = reversalExternalId;
     }
 
+    public void reverseWithExternalIdHandling(final boolean isReverseReplayed) 
{

Review Comment:
   This is not needed! I dont wanna move "reverse-replay" logic into the 
LoanTransaction entity...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to