adamsaghy commented on code in PR #4246:
URL: https://github.com/apache/fineract/pull/4246#discussion_r1907588629
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -809,7 +808,11 @@ protected void createNewTransaction(final LoanTransaction
oldTransaction, final
relations.add(LoanTransactionRelation.linkToTransaction(originalTransaction,
newTransaction, CHARGEBACK));
}
loanChargeValidator.validateRepaymentTypeTransactionNotBeforeAChargeRefund(oldTransaction.getLoan(),
oldTransaction, "reversed");
- oldTransaction.reverse();
+
Review Comment:
THis is not needed. The issue was not with this logic!
Here there will always be "REPLAYED" relation, so checking it again is
unnecessary!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
