adamsaghy commented on code in PR #4294:
URL: https://github.com/apache/fineract/pull/4294#discussion_r1949812399
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/data/InterestPeriod.java:
##########
@@ -116,6 +146,13 @@ public void updateOutstandingLoanBalance() {
}
}
+ /**
+ * Include principal like amounts (all disbursement amount + chargeback
principal)
+ */
+ public Money getDisbursedAmounts() {
Review Comment:
Again... if it is called "disbursed" amounts, than it cannot contains
chargebacks... either keep this elsewhere or you can have a
"getCreditedAmounts" which contains disbursed amounts and charged back amounts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
