somasorosdpc commented on code in PR #4294:
URL: https://github.com/apache/fineract/pull/4294#discussion_r1950489725
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/data/ProgressiveLoanInterestScheduleModel.java:
##########
@@ -212,10 +215,14 @@ private Consumer<RepaymentPeriod>
updateInterestPeriodOnRepaymentPeriod(final Lo
}
private Optional<InterestPeriod> findInterestPeriodForBalanceChange(final
RepaymentPeriod repaymentPeriod,
- final LocalDate balanceChangeDate) {
+ final LocalDate balanceChangeDate, final boolean
isChangeOnMaturityDate) {
if (repaymentPeriod == null || balanceChangeDate == null) {
return Optional.empty();
}
+ if (isChangeOnMaturityDate) {
Review Comment:
If we have a pre maturity chargeback, we should display it on the "next
day's" installment. If we are on maturity date, we should add chargeback to the
current (last) installment ( after maturity we create N+1th installment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
