adamsaghy commented on code in PR #4350:
URL: https://github.com/apache/fineract/pull/4350#discussion_r1961670285
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -3092,6 +3098,15 @@ public CommandProcessingResult chargeOff(JsonCommand
command) {
final List<Long> existingTransactionIds =
loan.findExistingTransactionIds();
final List<Long> existingReversedTransactionIds =
loan.findExistingReversedTransactionIds();
+ final LoanChargeOffBehaviour chargeOffBehaviour =
loan.getLoanProductRelatedDetail().getChargeOffBehaviour();
Review Comment:
I think it would be better to handle inside the Transaction processor as we
need similar logic in case a reverse-replay occurs and we need to create
additional Accrual or Accrual adjustment as a side effect. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
