mariiaKraievska commented on code in PR #4350:
URL: https://github.com/apache/fineract/pull/4350#discussion_r1967354473


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -3745,4 +3760,39 @@ public void closeAsMarkedForReschedule(final Loan loan, 
final JsonCommand comman
 
         loanTransactionValidator.validateLoanRescheduleDate(loan);
     }
+
+    private void createMissingAccrualTransactionIfNeeded(final BigDecimal 
newInterest, final Loan loan, final LocalDate chargeOffDate) {

Review Comment:
   I considered moving this logic into the LoanAccrualProcessingService, but 
unfortunately, it wasn't feasible. Doing so introduces a circular dependency 
issue, making it impossible to use the service within the 
AdvancedPaymentScheduleTransactionProcessor. Therefore, I decided to move it in 
the AdvancedPaymentScheduleTransactionProcessor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to