oleksii-novikov-onix commented on code in PR #4352: URL: https://github.com/apache/fineract/pull/4352#discussion_r1961902629
########## fineract-core/src/main/java/org/apache/fineract/infrastructure/event/business/service/ExternalBusinessEventConfigurationServiceImpl.java: ########## @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.infrastructure.event.business.service; + +import lombok.RequiredArgsConstructor; +import org.apache.fineract.infrastructure.event.external.repository.ExternalEventConfigurationRepository; +import org.springframework.stereotype.Service; + +@Service +@RequiredArgsConstructor +public class ExternalBusinessEventConfigurationServiceImpl implements ExternalBusinessEventConfigurationService { Review Comment: I believe we need to define a configuration class and create the bean manually using `@Bean` + `@ConditionalOnMissingBean`, as we do for many other services. Otherwise, if someone plans to override the default behavior in a custom module, they would be required to exclude the default implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
