adamsaghy commented on code in PR #4352:
URL: https://github.com/apache/fineract/pull/4352#discussion_r1967374585
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/event/business/service/BusinessEventNotifierServiceImpl.java:
##########
@@ -100,7 +99,7 @@ public void notifyPostBusinessEvent(BusinessEvent<?>
businessEvent) {
}
if (isExternalEvent && isExternalEventPostingEnabled()) {
// we only want to create external events for operations that were
successful, hence the post listener
- if (isExternalEventConfiguredForPosting(businessEvent.getType())) {
+ if
(externalBusinessEventConfigurationService.isExternalEventConfiguredForPosting(businessEvent.getType()))
{
Review Comment:
You might wanna provide the whole business event, instead of the type only.
It provides more options to any alternative implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
