VictorPavfurious commented on code in PR #4347:
URL: https://github.com/apache/fineract/pull/4347#discussion_r1961638099
##########
fineract-rates/src/main/java/org/apache/fineract/portfolio/floatingrates/api/FloatingRatesApiResource.java:
##########
@@ -79,11 +73,10 @@ public class FloatingRatesApiResource {
@RequestBody(required = true, content = @Content(schema =
@Schema(implementation =
FloatingRatesApiResourceSwagger.PostFloatingRatesRequest.class)))
@ApiResponses({
@ApiResponse(responseCode = "200", description = "OK", content =
@Content(schema = @Schema(implementation =
FloatingRatesApiResourceSwagger.PostFloatingRatesResponse.class))) })
- public String createFloatingRate(@Parameter(hidden = true) final String
apiRequestBodyAsJson) {
-
- final CommandWrapper commandRequest = new
CommandWrapperBuilder().createFloatingRate().withJson(apiRequestBodyAsJson).build();
- final CommandProcessingResult result =
this.commandsSourceWritePlatformService.logCommandSource(commandRequest);
- return this.toApiJsonSerializer.serialize(result);
+ public CommandProcessingResult createFloatingRate(@Parameter(hidden =
true) final @Valid FloatingRateRequest floatingRateRequest) {
Review Comment:
final Valid ?? Do you use jakarta annotations somewhere ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
